Add Choice field type #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…framework classes until render time
Similar to the concept of Symphony's ChoiceType field, allows for easy runtime decisions on how to render an input. Uses methods multiple(bool) and expanded(bool) to decide what form fields to render. multiple: false and expanded: false = select multiple: true and expanded: false = multiselect multiple: false and expanded: true = radios multiple: true and expanded: true = checkboxes Also simplifies the provisioning of choices with a choices() method. I would prefer to expand on this by creating ChoiceGroup and Choice objects instead of trying to interepret the developer's intent from the object passed in.
|
I do think this should likely be merged; sorry for the delay. I haven't had the time to review and test this properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request has three main features, two of them related.