Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bootstrap 4 validation messages not being colored red #579

Merged
merged 4 commits into from
Jan 30, 2019
Merged

Fix Bootstrap 4 validation messages not being colored red #579

merged 4 commits into from
Jan 30, 2019

Conversation

stayallive
Copy link
Contributor

I have not touched the other frameworks because time and not having all the knowledge. However this opens up the possibility to differentiate between validation error help messages and just plain help messages (like a user would post).

Also fixed Bootstrap 4 needing is-invalid instead of has-error and add that class to the actual input element, on the group it has no effect.

Also some fixes to the actual help blocks and matched them to how they're displayed in the documentation, relevant sections:

Result:

image

@yannrobin
Copy link

Hello,

Any Ideas of when this will be pushed as an update ?

Thanks

Copy link
Member

@claar claar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix spaces vs tabs issues with surrounding lines.

edit: Looking closer, it appears the spaces vs tabs issue was just in Github's code review page; checking out the code locally, the indentation is perfect. Sorry about that! Nice job.

@claar claar merged commit 3834c22 into formers:master Jan 30, 2019
@claar
Copy link
Member

claar commented Jan 30, 2019

@yannrobin Thanks for the nudge -- merged and released in 4.1.11.

@yannrobin
Copy link

Thanks for that, It will be helpful

@stayallive stayallive deleted the patch-1 branch January 31, 2019 07:15
@stayallive
Copy link
Contributor Author

Thanks! :)

@claar
Copy link
Member

claar commented Jan 31, 2019

Thanks for contributing, @stayallive !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants