Fixed required validation considering false value falsy #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendanbond
requested changes
Feb 19, 2024
| expect(result).to.equal(null); | ||
| }); | ||
|
|
||
| it('Validating a simple component that is required and present in the data with value=false will return null', async () => { |
There was a problem hiding this comment.
This isn't really a valid test case, because the data from a text field will never be false under normal circumstances. Can we update this test to include a radio component and a checkbox component?
|
Hi @brendanbond |
brendanbond
approved these changes
Apr 17, 2024
|
We need to revert this PR because it broke Checkbox "required" validations. If you have a required checkbox, it lets you not click it. |
travist
added a commit
that referenced
this pull request
Apr 18, 2024
Revert "Merge pull request #31 from ralfeis/master"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this is a fix for: formio/formio.js#5457
Best regards
Ralf