Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO 8049: fix value prop in evaluations #56

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

brendanbond
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8049

Description

  • Since value is now a getter, we need to make it enumerable so that the Evaluator [correctly enumerates it]( into the arguments of the Function
  • We also want to make sure that the component's value, if it exists, is passed in to the evaluation context

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

I added an automated test to describe behavior and the existing formio and formio-server tests are passing.

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@AlexeyNikipelau AlexeyNikipelau merged commit d938380 into master Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants