Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8079: add stricter time validation #61

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

brendanbond
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8079

Description

This PR adds a normalization step that takes time components that are valid in the default time component format ("HH:mm") and coerces them into the dataFormat format (e.g. "HH:mm:ss"). Effectively, this will allow submissions that conform to either format while still validating correct times.

Breaking Changes / Backwards Compatibility

It seems like we never really validated time components on the server (try submitting "10:0" or "10:" to a form with a time component via API on recent release branches), so there may be a risk that customers that are used to the status quo of no validation may run into problems. Additionally, the new stricter validation scheme will also reject invalid times that are in the correct format (e.g. "25:00:00"), which previously might have been parsed as "24 hours + 1 hour into the next day."

Dependencies

n/a

How has this PR been tested?

manually and added automated tests

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@travist
Copy link
Member

travist commented Mar 21, 2024

👍

@travist travist merged commit 581a480 into master Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants