FIO-8079: add stricter time validation #61
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-8079
Description
This PR adds a normalization step that takes time components that are valid in the default time component
format
("HH:mm") and coerces them into thedataFormat
format (e.g. "HH:mm:ss"). Effectively, this will allow submissions that conform to either format while still validating correct times.Breaking Changes / Backwards Compatibility
It seems like we never really validated time components on the server (try submitting "10:0" or "10:" to a form with a time component via API on recent release branches), so there may be a risk that customers that are used to the status quo of no validation may run into problems. Additionally, the new stricter validation scheme will also reject invalid times that are in the correct format (e.g. "25:00:00"), which previously might have been parsed as "24 hours + 1 hour into the next day."
Dependencies
n/a
How has this PR been tested?
manually and added automated tests
Checklist: