Skip to content
This repository has been archived by the owner on Apr 30, 2018. It is now read-only.

add optional sr-only to label #51

Closed
shanemgrey opened this issue Sep 17, 2015 · 2 comments
Closed

add optional sr-only to label #51

shanemgrey opened this issue Sep 17, 2015 · 2 comments

Comments

@shanemgrey
Copy link
Contributor

when sr-only is a class on the label, the label will hide for
non-screen-reader clients

I've made a feature branch to do this at https://github.com/shanemgrey/angular-formly-templates-bootstrap/tree/feature/sr-only

accepts an optional templateOption of labelSrOnly, which, if true, hides the label for
non-screen-reader clients

Only changes 2 lines of code (3 if you count the additional comma ;-)

Can you review my branch and let me know if you want a PR?

@kentcdodds
Copy link
Member

Looks awesome. Feel free to PR.

On Thu, Sep 17, 2015, 10:08 AM shanemgrey notifications@github.com wrote:

when sr-only is a class on the label, the label will hide for
non-screen-reader clients

I've made a feature branch to do this at
https://github.com/shanemgrey/angular-formly-templates-bootstrap/tree/feature/sr-only

accepts an optional templateOption of labelSrOnly, which, if true, hides
the label for
non-screen-reader clients

Only changes 2 lines of code (3 if you count the additional comma ;-)

Can you review my branch and let me know if you want a PR?


Reply to this email directly or view it on GitHub
#51
.

@shanemgrey
Copy link
Contributor Author

Thanks for merging!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants