Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing missing childNode error #129

Merged
merged 1 commit into from
Jun 21, 2024
Merged

fix: removing missing childNode error #129

merged 1 commit into from
Jun 21, 2024

Conversation

Zjjc123
Copy link
Contributor

@Zjjc123 Zjjc123 commented Jun 20, 2024

Only remove the child if iframe still contains contentDocument. If user clicks on the close hyperlink in the embed, contentDocument will be removed.

should fix: #128

or some fix along the line of this

Only remove the child if iframe still contains contentDocument. If user clicks on the close hyperlink in the embed, contentDocument will be removed.
@alikirec alikirec self-requested a review June 21, 2024 11:12
Copy link
Contributor

@alikirec alikirec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for the fix!

@alikirec alikirec merged commit e5010f1 into formsort:master Jun 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Closing forms using the close hypertext in the embed crashes the embed component
2 participants