Loosen react dep allowing 16+, add ReactDOM to externals

[apuntovanini]

This can be a WIP for allowing React 16. Tests passed without problems, still need to check in some concrete examples, but no big issues so far.
Am I missing something? Seemed too easy, there must be something I am missing out 😄

[apuntovanini]

Ok, I can confirm: I tested with React 16 on multiple inputs and it works. One of the issues that may arise is (and that happened to me was) TypeError: this.updater.enqueueCallback twisty/formsy-react-components#118
The issue is related to mismatching versions of React, and not related to Formsy.
A non blocking issue I found out is related to #4 on select controls

[apuntovanini]

This fixes #7

[rkuykendall]

From what I can tell, this looks good. I'll try to get it running on my project again today. One odd thing is the release folder being included in the PR. Should we do that? Seems like it would be fragile in merges. I imagined we would only update that in release commits where we updated the version numbers, but I don't know.

[apuntovanini]

Nope, you're right, release folder shouldn't be in the PR unless we want to let users try importing UMD versions. Lib folder instead should be included, since it targets es5 projects, and it's needed in many cases, but thats my opinion. We can allow both using package.json, whats your idea?

[MilosRasic]

We should put whatever package.json main is pointing to (currently lib) in the repo if we want people to be able to use it with github urls in package.json. Currently npm install git+https://github.com/formsy/formsy-react.git doesn't work because lib is missing.

[apuntovanini]

@MilosRasic if you use it from repo directly yes, you'd need lib folder. We should keep it in the repo until the React 16 support PR (1.1.0) in order to allow us to test it from git directly. But later on we'll need to remove it and make it available only in the npm package, not in repo. I added it back in this PR, so you can test it

[MilosRasic]

@apuntovanini Thanks. I'd also like to test with 1.0.1 before switching to the React 16 branch. Can someone please release 1.0.1 on npm? @rkuykendall, @twisty ?

[apuntovanini]

If we release master branch we won't have access to lib anyway, can you send a PR for the lib folder added in the repo? This PR needs more tests to land in master, so we need another @MilosRasic

[rkuykendall]

@apuntovanini @MilosRasic Looks like I have NPM access. I'll create a PR to add lib and bump the version number.

[apuntovanini]

Cool! That means that I do have access as well? :) Inviato da iPhone Il giorno 13 nov 2017, alle ore 15:28, Miloš Rašić <notifications@github.com<mailto:notifications@github.com>> ha scritto: @apuntovanini<https://github.com/apuntovanini> Thanks. I'd also like to test with 1.0.1 before switching to the React 16 branch. Can someone please release 1.0.1 on npm? @rkuykendall<https://github.com/rkuykendall>, @twisty<https://github.com/twisty> ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#11 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABGyZQXpmhW8jhoKQ3i00kGR2ZSGWYVmks5s2FIggaJpZM4QY1og>.

[rkuykendall]

I don't think so? Is one of these you? I'm actually not that familiar with how NPM manages permissions.

npm access ls-collaborators formsy-react
{
  "rkuykendall": "read-write",
  "sdemjanenko": "read-write",
  "twisty": "read-write",
  "track0x1": "read-write",
  "st-andrew": "read-write",
  "aesopwolf": "read-write",
  "semigradsky": "read-write",
  "christianalfoni": "read-write"
}

[rkuykendall]

I bumped the version number and ran yarn build but the src folder didn't change. Release folder did. #16

[apuntovanini]

Ok, no 😢 I don't have access. I'll ask @aesopwolf to add me if I gained enough trust 😄

[rkuykendall]

@apuntovanini Did the rebase go sideways? It seems like the PR now contains a lot of commits / changes that have already been applied to master, which is odd.

[apuntovanini]

Ok, I may’ve got lost in this, but as of my understanding now the PR is aligned with 1.0.2 and the merge would work. But to be honest I always get lost in PR that should be realigned with master... what do you suggest?

[MilosRasic]

Ok, I've tested the 1.0.2 with https://github.com/gogoair/react-formsy-combo-select with the latest version of React installed. For some reason my version of npm didn't duplicate React even though formsy-react requires ^15.6.1. Everything works fine, no warnings or other issues. Can we resolve the rebase issue and merge tihs? I'm afraid I can't help much since I don't have much experience with rebasing. @apuntovanini maybe you can just squash some of the commits into one?

Either way, it will take some time to move my multi-repo project at work to React 16, and I'm on vacation, so I wouldn't like to hold this back. I'm in favour of just publishing 1.1.0 with React 16 support at this point. If we find something wrong we can always quickly publish a fix or two.

[apuntovanini]

@MilosRasic I think I'll close this PR in favour of a new one tonight, so that we can merge this. I agree with a 1.1.0 release, we can fix it either way if issues arise, and if we didn't release it we'd never find out 😄 , so, yes, I'll be working on it tonight and we'll be ready to go!

[rkuykendall]

If we find something wrong we can always quickly publish a fix or two.

Yeah, we're going to make mistakes, but I think that's better than being frozen by doubt. If we just keep this project moving and very responsive to feedback / bug reports and we should be fine.