Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plug in the ErrorHandlers for JSON/color compatibility of http lib logging #812

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

ldemailly
Copy link
Member

@ldemailly ldemailly commented Aug 4, 2023

Fixes #802

Through support from fortio.org/log@1.10.0 (scli 1.11.0)
ie fortio/log#44

See manual test in fortio/proxy#145

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 92.4% and project coverage change: -1.1% ⚠️

Comparison is base (abdbd19) 89.7% compared to head (057e56b) 88.5%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #812     +/-   ##
========================================
- Coverage    89.7%   88.5%   -1.1%     
========================================
  Files          17      17             
  Lines        4141    4983    +842     
========================================
+ Hits         3713    4412    +699     
- Misses        279     422    +143     
  Partials      149     149             
Files Changed Coverage Δ
fnet/network.go 89.5% <75.0%> (-0.9%) ⬇️
rapi/restHandler.go 86.4% <87.0%> (-0.8%) ⬇️
periodic/periodic.go 92.7% <92.0%> (-1.1%) ⬇️
fhttp/http_server.go 81.7% <100.0%> (-4.2%) ⬇️
fhttp/httprunner.go 91.8% <100.0%> (-0.3%) ⬇️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ldemailly ldemailly changed the title Fix #802 - plug in the ErrorHandlers Plug in the ErrorHandlers for JSON/color compatibility of http lib logging Aug 4, 2023
@ldemailly ldemailly merged commit fef3d6d into master Aug 4, 2023
6 of 7 checks passed
@ldemailly ldemailly deleted the fix_802 branch August 4, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

connect http library logging into fortio structured logger
2 participants