Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runall.sh does not detect failures in lower-level runalltestcases.sh #539

Closed
infinnovation-dev opened this issue Dec 6, 2018 · 1 comment

Comments

@infinnovation-dev
Copy link

I ran runall.sh on a codebase where a unit test in a subdirectory was known to fail. The failure was not detected, giving the false impression that all tests has succeeded.

$ NO_REMOTE=y ./runall.sh
...
F
 ======================================================================
 FAIL: test_str (__main__.DNSTests)
 ----------------------------------------------------------------------
 Traceback (most recent call last):
 File "test_dns.py", line 28, in test_str
 "DNS RESPONSEn"
 File "test_dns.py", line 8, in chk
 self.assertEqual(str(DNS(b)),t)
 AssertionError: ...
...
 Ran 1 test in 0.001s
 
 FAILED (failures=1)
 ...
NO ERRORS found, congrats!

runall.sh tests for overall failure by grepping for ERROR in $OUTPUTFILE, but runalltestcases.sh scripts do not output this string.

infinnovation-dev pushed a commit to infinnovation-dev/impacket that referenced this issue Dec 6, 2018
@asolino
Copy link
Collaborator

asolino commented Dec 6, 2018

Great catch here @infinnovation-dev

@asolino asolino closed this as completed Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants