Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type-based DCT procedure names #38

Merged
merged 5 commits into from
Mar 23, 2023
Merged

Add type-based DCT procedure names #38

merged 5 commits into from
Mar 23, 2023

Conversation

cval26
Copy link
Contributor

@cval26 cval26 commented Mar 15, 2023

Implements item 2 of #34.

Creates the following procedure aliases by overloading the existing DCT procedures, so that they can be called with names based on their DCT types (1, 2, 3). The following procedure aliases are created.

  • dct_t1i and dct_t1 corresponding to dcosti and dcost;
  • dct_t23i corresponding to dcosqi;
  • dct_t2 and dct_t3 corresponding to dcosqb and dcosqf.

These correspond to the operations:

  • initialize and perform DCT-1;
  • initialize DCT-2, 3;
  • perform DCT-2, 3.

src/fftpack.f90 Outdated Show resolved Hide resolved
@cval26
Copy link
Contributor Author

cval26 commented Mar 19, 2023

@zoziha, this is now ready for review.

@cval26 cval26 marked this pull request as ready for review March 19, 2023 14:27
Copy link
Contributor

@zoziha zoziha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cval26 , the content looks good. I think it can be passed quickly.

src/fftpack.f90 Outdated Show resolved Hide resolved
@zoziha
Copy link
Contributor

zoziha commented Mar 22, 2023

Thank you for this @cval26 . Is there anything more to submit?
If not, we can merge it.

@cval26
Copy link
Contributor Author

cval26 commented Mar 22, 2023

We can merge this, @zoziha.

@zoziha zoziha merged commit 113982e into fortran-lang:main Mar 23, 2023
@cval26 cval26 deleted the dct-types branch March 23, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants