ci: add windows workflow #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be advantageous to have distinct workflows on a per-operating system basis, to quickly see the scope of a failure
|
Thanks! You can upgrade cmake, or do whatever needs to be done to make all tests pass. |
Merged
|
I am trying to trouble shoot this in #61. Is this a compiler bug? |
|
I think it is a compiler bug it's not uncommon to find such things with rarer configurations like quad precision. |
|
I see. Why don't we disable quad precision for now. I think having Windows tests is essential (more important than quad precision). Then we can re-enable quad precision in future PRs on platforms where it works. |
|
This was merged as part of #61. Thanks @scivision! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be advantageous to have distinct workflows on a per-operating system basis,
to quickly see the scope of a failure.
This CI will fail until the quad-precision code is made conditional on a build system test (CMake >= 3.14
check_fortran_source_runs()) to make quad-precision optional in library and tests.In the library, this can be done via Fortran
submodule. In the test, it can be done via preprocessor#ifdef usereal128or similar introduced via CMake as a result of configure checks