Update #302
Merged
Update #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The helper.ts file was cluttered, filled with routines and variables that belonged to the tools file. This have now been moved. In addition, the old interface with the language server has been removed in preparation for the new interface that will be added.
We can still use yarn if we want but the lockfile will not be stored anymore. The reason being that yarn does not work with the git hooks for precommits we have setup. We could probably get it to work but npm works already so one package manages is enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks some changes present on the dev branch to minimise the diffs in the main dev branch.
The most important thing in this PR is dropping yarn. Dependabot seems to not be upgrading it properly i.e. passing it through lint
so it is easier to use
npm cialmost equally fast.