Use an interface rather than concrete type for testing.T #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortytw2
requested changes
Dec 9, 2016
| @@ -17,8 +16,12 @@ func init() { | |||
| flag.Parse() | |||
| } | |||
|
|
|||
| type TestingT interface { | |||
There was a problem hiding this comment.
Call this TestReporter instead, I think 😄
|
I was following the method used by testify but I'll change it if you like |
|
Ah cool, prior art. Fair enough! Thanks for your help 😄 |
fortytw2
approved these changes
Dec 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preventing me from using a spec runner as
*testing.Tisn't provided, but an implementation of it is