This repository has been archived by the owner on Jun 28, 2019. It is now read-only.
allow tag value delimiter to be configurable #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this be getting merged? +1 from me... knife ec2 doesn't allow comma separated tags so this causes issues with chef provisioned servers. They already split their tags arg on commas for different tags. |
|
@gpeng In the meantime you can use this in your Gemfile: gem 'cap-ec2', require: false, git: "git@github.com:erez-rabih/cap-ec2.git", branch: "custom-delimiter"I have been working this way for the past two months. |
|
@erez-rabih Thanks... I forked it from you for now. Hopefully it'll get merged 👍 |
|
Rebase? |
|
Happy to merge this if it gets rebased @erez-rabih |
|
@dlahn I merged with master |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #49