Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to select individual sources for display #116

Merged
merged 1 commit into from
Mar 20, 2013

Conversation

fedxa
Copy link
Contributor

@fedxa fedxa commented Mar 20, 2013

I added the possibility to select individual sources for display.

The list of sources appears below the tags list in the navigation panel. It is also possible to hide the list of sources (or tags) by clicking at the title 'Sources' (or 'Tags').

Possible further improvements:
  • I guess, it would be also nice to add some symbol (+ or -) to the Tags/Sources h2 element to show, that the list it hidden/expanded.
  • I really think, that 'padding: 5px' should be removed from '#nav-tags li' style, but I am not changing this in the pull request -- let Tobias decide this.
  • The mobile setup is not really tested in any way.
  • There is a bug -- if the Tag name is long, the unread count for the Tag will be squashed (fixed for sources unread counts only)

SSilence added a commit that referenced this pull request Mar 20, 2013
Added the ability to select individual sources for display
@SSilence SSilence merged commit bc317ae into fossar:master Mar 20, 2013
@SSilence
Copy link
Member

Thanks for this great pull request. A really good solution especially with the ability to hide the tags or sources!

@fedxa
Copy link
Contributor Author

fedxa commented Mar 20, 2013

Thanks!

PS. And, as last time -- I forgot to fix the PostgreSQL backend...

@pietheinstrengholt
Copy link

There's a flaw in this one. The items aren't clickable. Maybe this is something you can have a look at?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants