-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding an in-built Subscribe button #4
Comments
@0x48piraj Can you please elaborate? |
Indeed. @prshntsingh 👍 |
@0x48piraj Can I work on this issue? |
Absolutely. Start right away! |
Okay🙂 |
Any Updates @prshntsingh ? |
@0x48piraj was busy with my institute exams.I will work on it this weekend. |
Updates @prshntsingh ? |
@0x48piraj sorry for late reply.Actually my institute exams are going on. I will do it as soon as it gets over. |
@0x48piraj @prshntsingh I would like to add subscribe button. Can I work on this? |
Definitely! |
@0x48piraj Actually I've added the subscribe button and it's working completely fine for chrome but transitions in firefox are broken, I don't know why (I'm using Jquery's fadeIn() and hide())... Screenshot for Chrome Screenshot for firefox Should I first fix it for firefox then open a PR or just open a PR so that other people could help in it?? |
Hey, I worked on this issue and opening a pull request. See to it. |
@0x48piraj I have fixed this under the issue #33 . Suggest other changes. |
any work left on this issue? |
Link the Pull Request. |
I have fixed the issue. I will generate a PR on Mar 1. |
Hey I can build the subscribe button but I know the web scraping with puppeteer so should I commit the extension built on puppeteer or You can explain what u have used in this extension. |
Current State :
No such implementation yet.
Expected Outcome :
A Subscribe button to let users subscribe to FOSSASIA.
The text was updated successfully, but these errors were encountered: