Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an in-built Subscribe button #4

Open
0x48piraj opened this issue Jan 18, 2018 · 18 comments
Open

Adding an in-built Subscribe button #4

0x48piraj opened this issue Jan 18, 2018 · 18 comments

Comments

@0x48piraj
Copy link
Member

Current State :

No such implementation yet.

Expected Outcome :

A Subscribe button to let users subscribe to FOSSASIA.

@prshntsingh
Copy link
Contributor

@0x48piraj Can you please elaborate?
By "subscribe to FOSSASIA" do you mean to subscribe to Fossasia's mail?

@0x48piraj
Copy link
Member Author

Indeed. @prshntsingh 👍

@prshntsingh
Copy link
Contributor

@0x48piraj Can I work on this issue?

@0x48piraj
Copy link
Member Author

Absolutely. Start right away!

@prshntsingh
Copy link
Contributor

Okay🙂

@0x48piraj
Copy link
Member Author

Any Updates @prshntsingh ?

@prshntsingh
Copy link
Contributor

@0x48piraj was busy with my institute exams.I will work on it this weekend.

@0x48piraj
Copy link
Member Author

Updates @prshntsingh ?

@prshntsingh
Copy link
Contributor

@0x48piraj sorry for late reply.Actually my institute exams are going on. I will do it as soon as it gets over.

@Rishabh570
Copy link
Contributor

@0x48piraj @prshntsingh I would like to add subscribe button. Can I work on this?

@0x48piraj
Copy link
Member Author

Definitely!
Go on!

@Rishabh570
Copy link
Contributor

@0x48piraj Actually I've added the subscribe button and it's working completely fine for chrome but transitions in firefox are broken, I don't know why (I'm using Jquery's fadeIn() and hide())...

Screenshot for Chrome

main-layout

subscribe-form

Screenshot for firefox

buggy

Should I first fix it for firefox then open a PR or just open a PR so that other people could help in it??

@mohitsharma23
Copy link

Hey, I worked on this issue and opening a pull request. See to it.

championpaddler added a commit to championpaddler/Connect-Me that referenced this issue Oct 1, 2018
@NirmalKumarJoshi
Copy link

@0x48piraj I have fixed this under the issue #33 . Suggest other changes.

@HemabhKamboj
Copy link
Member

any work left on this issue?

@0x48piraj
Copy link
Member Author

Link the Pull Request.

@NirmalKumarJoshi
Copy link

I have fixed the issue. I will generate a PR on Mar 1.

@ShubhamChaudharyy
Copy link

ShubhamChaudharyy commented Oct 7, 2019

Hey I can build the subscribe button but I know the web scraping with puppeteer so should I commit the extension built on puppeteer or You can explain what u have used in this extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment