Fixes #687 : Basic Login and Register #688

gabru-md · 2018-05-04T11:45:29Z

Fixes #687

Checklist

I have read the Contribution & Best practices Guide and my PR follows them.
My branch is up-to-date with the Upstream development branch.
I have added necessary documentation (if appropriate)

Preview Link

Replace XXX with your PR no
Link to live demo: http://pr-XXX-fossasia-badgeyay.surge.sh

Changes proposed in this pull request:

Adds basic login and Register

Adds User Login and Register functionality to Badgeyay API. Cheers! Adds Git Ignore

houndci-bot · 2018-05-04T11:45:39Z

backend/blueprint/api/utils/verifyPassword.py

+def verifyPassword(user, password):
+    return check_password_hash(
+        user.password,
+        password)


no newline at end of file

houndci-bot · 2018-05-04T11:45:39Z

backend/blueprint/api/utils/verifyPassword.py

@@ -0,0 +1,6 @@
+from werkzeug.security import check_password_hash
+
+def verifyPassword(user, password):


expected 2 blank lines, found 1

houndci-bot · 2018-05-04T11:45:39Z

backend/blueprint/api/run.py


-app.run()
+db.init_app(app)


expected 2 blank lines after class or function definition, found 1

houndci-bot · 2018-05-04T11:45:39Z

backend/blueprint/api/run.py

 app.register_blueprint(homePage.router)
 app.register_blueprint(errorHandlers.router)

+@app.before_first_request


expected 2 blank lines, found 1

houndci-bot · 2018-05-04T11:45:40Z

backend/blueprint/api/models/user.py

+    name = db.Column(db.String(80))
+
+
+    def __init__(self, username, password, name):


too many blank lines (2)

houndci-bot · 2018-05-04T11:45:40Z

backend/blueprint/api/controllers/registerUser.py

+        data['username'],
+        data['password'],
+        data['name']
+        )


closing bracket does not match indentation of opening bracket's line

houndci-bot · 2018-05-04T11:45:41Z

backend/blueprint/api/controllers/loginUser.py

+
+    return jsonify(
+        Response(403).generateMessage(
+            'No data received'))


no newline at end of file

houndci-bot · 2018-05-04T11:45:41Z

backend/blueprint/api/controllers/loginUser.py

+
+        token = jwt.encode(
+            {'user' : user.username,
+            'exp' : datetime.datetime.utcnow() + datetime.timedelta(seconds=900)},


continuation line under-indented for visual indent
whitespace before ':'

houndci-bot · 2018-05-04T11:45:41Z

backend/blueprint/api/controllers/loginUser.py

+                    'Wrong username & password combination'))
+
+        token = jwt.encode(
+            {'user' : user.username,


whitespace before ':'

houndci-bot · 2018-05-04T11:45:41Z

backend/blueprint/api/controllers/loginUser.py

+                Response(403).generateMessage(
+                    'Could not find the Username Specified'))
+
+        if not verifyPassword(user,data['password']):


missing whitespace after ','

gabru-md · 2018-05-04T11:48:03Z

CC : @djmgit @ParthS007

Please ignore the song in background 😆

codecov · 2018-05-04T11:50:18Z

Codecov Report

Merging #688 into development will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           development   #688   +/-   ##
==========================================
  Coverage          100%   100%           
==========================================
  Files                1      1           
  Lines               43     43           
==========================================
  Hits                43     43

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c14622...33dfdcc. Read the comment docs.

houndci-bot · 2018-05-04T11:51:20Z

backend/blueprint/api/controllers/registerUser.py

+        data['name'])
+
+    try:
+        newUser.save_to_db()    


trailing whitespace

houndci-bot · 2018-05-04T11:55:10Z

backend/blueprint/api/utils/verifyPassword.py

+    return check_password_hash(
+        user.password,
+        password)
+


blank line at end of file

houndci-bot · 2018-05-04T11:55:10Z

backend/blueprint/api/controllers/loginUser.py

+    return jsonify(
+        Response(403).generateMessage(
+            'No data received'))
+


blank line at end of file

djmgit

Nicely done 👍
Please solve the hound errors

houndci-bot · 2018-05-04T12:04:32Z

backend/blueprint/api/db.py

+from flask_sqlalchemy import SQLAlchemy
+
+db = SQLAlchemy()
+


blank line at end of file

Fixes Hound2 Fixes Hound3 Fixes Hound4 Fixes Hound

djmgit

This is nice to start with. In further iterations we can decide what fields need to present while registration. We can collect email and other stuff, need to discuss on that. Also other stuff like restrictions on password, email check, etc.

gabru-md · 2018-05-04T12:32:56Z

Sure @djmgit
There are a lot of other things to be added. I'll be adding them along with @ParthS007 as we claimed the issue together( for backend API ). Meanwhile @yashLadha can work on refractoring the current codebase so that when we shift it to the new API, then everything is working?

your views : @djmgit @ParthS007 ?

djmgit · 2018-05-04T12:33:19Z

@yashLadha (unable to tag you from reviewers list, don't know why :P) @ParthS007 please review

ParthS007

LGTM!

gabru-md added 2 commits May 3, 2018 01:20

Adds User Login and User Register

2ab63a0

Adds User Login and Register functionality to Badgeyay API. Cheers! Adds Git Ignore

Merges Changes

ea1f001

open-event-bot bot added the needs-review label May 4, 2018

open-event-bot bot assigned gabru-md May 4, 2018

houndci-bot reviewed May 4, 2018

View reviewed changes

backend/blueprint/api/controllers/registerUser.py Outdated

data['name'])

try:

newUser.save_to_db()

Copy link

houndci-bot May 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing whitespace

houndci-bot reviewed May 4, 2018

View reviewed changes

djmgit reviewed May 4, 2018

View reviewed changes

houndci-bot reviewed May 4, 2018

View reviewed changes

backend/blueprint/api/db.py Outdated

from flask_sqlalchemy import SQLAlchemy

db = SQLAlchemy()

Copy link

houndci-bot May 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line at end of file

gabru-md force-pushed the users branch 2 times, most recently from 30e11eb to 4e7bdf4 Compare May 4, 2018 12:20

Fixes Hound

83e0b8b

Fixes Hound2 Fixes Hound3 Fixes Hound4 Fixes Hound

gabru-md force-pushed the users branch 2 times, most recently from db11386 to 83e0b8b Compare May 4, 2018 12:27

Fixes Codacy

33dfdcc

djmgit approved these changes May 4, 2018

View reviewed changes

open-event-bot bot removed the needs-review label May 4, 2018

djmgit requested a review from ParthS007 May 4, 2018 12:31

ParthS007 approved these changes May 4, 2018

View reviewed changes

djmgit merged commit 1a21189 into fossasia:development May 4, 2018

open-event-bot bot added the ready-to-ship label May 4, 2018

gabru-md deleted the users branch May 4, 2018 18:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #687 : Basic Login and Register #688

Fixes #687 : Basic Login and Register #688

gabru-md commented May 4, 2018 •

edited

Loading

houndci-bot May 4, 2018

houndci-bot May 4, 2018

houndci-bot May 4, 2018

houndci-bot May 4, 2018

houndci-bot May 4, 2018

houndci-bot May 4, 2018

houndci-bot May 4, 2018

houndci-bot May 4, 2018

houndci-bot May 4, 2018

houndci-bot May 4, 2018

gabru-md commented May 4, 2018

codecov bot commented May 4, 2018 •

edited

Loading

houndci-bot May 4, 2018

houndci-bot May 4, 2018

houndci-bot May 4, 2018

djmgit left a comment

houndci-bot May 4, 2018

djmgit left a comment

gabru-md commented May 4, 2018 •

edited

Loading

djmgit commented May 4, 2018

ParthS007 left a comment

		@@ -0,0 +1,6 @@
		from werkzeug.security import check_password_hash

		def verifyPassword(user, password):

		name = db.Column(db.String(80))


		def __init__(self, username, password, name):


		app.run()
		db.init_app(app)

Fixes #687 : Basic Login and Register #688

Fixes #687 : Basic Login and Register #688

Conversation

gabru-md commented May 4, 2018 • edited Loading

Checklist

Preview Link

Changes proposed in this pull request:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gabru-md commented May 4, 2018

codecov bot commented May 4, 2018 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

djmgit left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

djmgit left a comment

Choose a reason for hiding this comment

gabru-md commented May 4, 2018 • edited Loading

djmgit commented May 4, 2018

ParthS007 left a comment

Choose a reason for hiding this comment

gabru-md commented May 4, 2018 •

edited

Loading

codecov bot commented May 4, 2018 •

edited

Loading

gabru-md commented May 4, 2018 •

edited

Loading