Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create sub pages with different filters #3

Closed
3 of 4 tasks
mariobehling opened this issue Sep 20, 2016 · 14 comments
Closed
3 of 4 tasks

Create sub pages with different filters #3

mariobehling opened this issue Sep 20, 2016 · 14 comments
Labels

Comments

@mariobehling
Copy link
Member

mariobehling commented Sep 20, 2016

The screenshot below shows different facettes/filters.

screenshot from 2016-10-15 15 44 05

Please implement it in the same style for

@FleetAdmiral
Copy link

I'd like to take this up! Anyone that could extend upon what is exactly expected over here?

@mariobehling
Copy link
Member Author

@FleetAdmiral Still interested? Please go ahead if you like. I also updated the description.

@FleetAdmiral
Copy link

@mariobehling Yea, i'll take it up. Thank you!

@mariobehling
Copy link
Member Author

@FleetAdmiral How is it going? Any questions?

@FleetAdmiral
Copy link

@mariobehling I'm currently preoccupied with my mid terms which get over on the 19th. I'll have to put off this work till then. I hope thats fine?
P.S: Thanks for checking up on me!

@mariobehling
Copy link
Member Author

@FleetAdmiral No problem. I unassign this, so someone else can take it up. There are enough issues to take up or if this is not solve just do it later. Cheers.

@hemantjadon
Copy link
Contributor

@mariobehling would it be nice to show the video and images (in the cards along with the results) in the all tab and then just filter those in different tabs essentially keeping the design same?

@mariobehling
Copy link
Member Author

@hemantjadon Yes, images and videos should be shown and currently are not displayed.

Then in the tabs for the start we simply show tweets with images or videos.

screenshot from 2016-10-17 20 06 52

@hemantjadon
Copy link
Contributor

@mariobehling @Orbiter
There is a certain issue which I am facing right now regarding the the images in individual posts

  • The api gives the image url in the images key of the as https://pic.twitter.com/{id}
  • Now on visiting this link redirects us to a url https://twitter.com/{user_name}/status/{post_id}/photos/{photo_number}. (an html response)
  • Thus this link cannot be directly used with the <img src="...">. (expected image response)
  • The actual image is located at a url like https://pbs.twimg.com/media/{id}, (taken from actual twitter feed)
  • Please suggest a method how the image can be obtained from the url of the api or any other method which will work.

@hemantjadon
Copy link
Contributor

Something i found on a twitter forum
https://twittercommunity.com/t/how-do-i-extract-the-url-to-the-photo-i-just-tweeted/7165/3

  • This is related to twitter api but i think it might point towards the right path.

@hemantjadon
Copy link
Contributor

@mariobehling
Any inputs on this will be helpful. Can't proceed without the images and videos loading.

@mariobehling
Copy link
Member Author

@hemantjadon It seems something has changed at twitter. We had it running in the webclient: https://github.com/fossasia/loklak_webclient and site still running at http://loklak.net

Please check out the way it was done in the webclient and adapt to the latest changes of twitter. Another option is to implement it in the loklak server: https://github.com/loklak/loklak_server

@Orbiter
Copy link
Contributor

Orbiter commented Oct 21, 2016

I will have a look at the back-end

@hemantjadon
Copy link
Contributor

@Orbiter
Sir any progress regarding this on backend?

Achint08 added a commit to Achint08/loklak_search that referenced this issue Mar 29, 2017
Achint08 added a commit to Achint08/loklak_search that referenced this issue Mar 29, 2017
Achint08 added a commit to Achint08/loklak_search that referenced this issue Mar 29, 2017
Achint08 added a commit to Achint08/loklak_search that referenced this issue Apr 11, 2017
Achint08 added a commit to Achint08/loklak_search that referenced this issue Apr 11, 2017
Achint08 added a commit to Achint08/loklak_search that referenced this issue Apr 11, 2017
Achint08 added a commit to Achint08/loklak_search that referenced this issue Apr 11, 2017
Achint08 added a commit to Achint08/loklak_search that referenced this issue Apr 12, 2017
Achint08 added a commit to Achint08/loklak_search that referenced this issue Apr 13, 2017
Achint08 added a commit to Achint08/loklak_search that referenced this issue Apr 14, 2017
Achint08 added a commit to Achint08/loklak_search that referenced this issue Apr 15, 2017
Achint08 added a commit to Achint08/loklak_search that referenced this issue Apr 15, 2017
Achint08 added a commit to Achint08/loklak_search that referenced this issue Apr 16, 2017
Achint08 added a commit to Achint08/loklak_search that referenced this issue Apr 16, 2017
Achint08 added a commit to Achint08/loklak_search that referenced this issue Apr 16, 2017
Achint08 added a commit to Achint08/loklak_search that referenced this issue Apr 19, 2017
Achint08 added a commit to Achint08/loklak_search that referenced this issue Apr 19, 2017
Achint08 added a commit to Achint08/loklak_search that referenced this issue Apr 20, 2017
mariobehling added a commit that referenced this issue May 2, 2017
Partially Fixes #3 : Added image and video subpage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants