Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #42: Add related hashtags component #127

Merged
merged 2 commits into from
Dec 16, 2016

Conversation

gupta-utkarsh
Copy link
Member

*Collect hashtags from the search results in decreasing order of frequency
*Display top 10 hashtags in the feed-footer

*Collect hashtags from the search results in decreasing order of frequency
*Display top 10 hashtag in the feed-footer
*Collect hashtags from the search results in decreasing order of frequency
*Display top 10 hashtag in the feed-footer
@gupta-utkarsh gupta-utkarsh changed the title Fix #42: Add related hashtags component Fixes #42: Add related hashtags component Dec 15, 2016
@mariobehling
Copy link
Member

Thanks.

Could you deploy it on your repository, so we can see how it works.

Also please add a screenshot to the PR.

Cheers.

@gupta-utkarsh
Copy link
Member Author

screenshot from 2016-12-15 18 24 56

Sure will deploy it asap. 👍

@hemantjadon
Copy link
Contributor

This seems good Nice work @uttu357 👍

@gupta-utkarsh
Copy link
Member Author

Deployed https://uttu357.github.io/loklak_search/search?query=amsterdam
You will need to enable loading of unsafe scripts as the api is on http and github pages are on https resulting in a mixed content warning.

@hemantjadon
Copy link
Contributor

@uttu357 This search is not working throwing MixedContent error.

As gh-pages uses https and api uses http followup the thread here for more details
#17

Well I can see that its working by "allowing unsafe scripts" and the code is working fine and PR can be merged. :)

@hemantjadon
Copy link
Contributor

@uttu357 @mariobehling I think changes are good thus I am merging this.

@uttu357 Nice Work. Would you like to add some unit tests for this component.

@gupta-utkarsh
Copy link
Member Author

Sure Ill work on adding unit tests for this component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants