-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
closed #60 & #61 #66
closed #60 & #61 #66
Conversation
Please ensure build tests are passing. Travis will pass then. |
@rishiraj824 errors are due to you don't have the latest code in your fork. |
Okay will check. Thanks. |
@rishiraj824 also for quick test you can run |
@mariobehling Please check the latest commit on the master branch. There shouldn't be any errors now. |
The errors in travis are from the home and the feed components. |
@hemantjadon Please help to resolve checks. @rishiraj824 Please provide a link to a test site. There is some text in red/pinkish color. These are supposed to link to internal search results e.g. #OpenData -- links to --> /search?query=#OpenData |
@rishiraj824
These should resolve all the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move styles to <component-name>.component.scss
rather than just below the html for uniformity in code base
</div> | ||
</div> | ||
<app-footer></app-footer> | ||
<style type="text/css"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move these To about.component.scss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay
</div> | ||
<app-footer></app-footer> | ||
|
||
<style type="text/css"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move these to contact.component.scss
@rishiraj824 Any questions regarding this issue at the moment? |
@mariobehling i fixed the issues #60 & #61 already. Please check my last commit. I thought the changes were merged. |
Ok, closing it. I am following up about more details in the related issue. |
@mariobehling Please check the commit for the issues #60 & #61 as assigned. Thank You.