closed #60 & #61

[rishiraj824]

@mariobehling Please check the commit for the issues #60 & #61 as assigned. Thank You.

[mariobehling]

Please ensure build tests are passing. Travis will pass then.

[hemantjadon]

@rishiraj824 errors are due to you don't have the latest code in your fork.
Please check :)

[rishiraj824]

Okay will check. Thanks.

[hemantjadon]

@rishiraj824 also for quick test you can run ng test and ng lint locally

[rishiraj824]

@mariobehling Please check the latest commit on the master branch. There shouldn't be any errors now.
this screenshot is of ng lint and ng test


This is the About Page #60

This is the contact page #61

[rishiraj824]

The errors in travis are from the home and the feed components.

[mariobehling]

@hemantjadon Please help to resolve checks.

@rishiraj824 Please provide a link to a test site.

There is some text in red/pinkish color. These are supposed to link to internal search results e.g. #OpenData -- links to --> /search?query=#OpenData

[hemantjadon]

@rishiraj824
I fixed these linting errors in last commit of mine.
Please safely pull that commit:

• Make a branch <branch-name> so that all your changes are safe.
• Then refer to this https://help.github.com/articles/syncing-a-fork/ for syncing your master branch with the main repo
• merge <branch-name> to master locally, reslove conflicts if any.
• push the changes.

These should resolve all the linting errors
Cheers :)

[hemantjadon]

Please move styles to <component-name>.component.scss rather than just below the html for uniformity in code base

[hemantjadon]

Move these To about.component.scss

[rishiraj824]

okay

[hemantjadon]

move these to contact.component.scss

[mariobehling]

@rishiraj824 Any questions regarding this issue at the moment?

[rishiraj824]

@mariobehling i fixed the issues #60 & #61 already. Please check my last commit. I thought the changes were merged.

[rishiraj824]

ng lint test on my local

[mariobehling]

Ok, closing it. I am following up about more details in the related issue.