Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search via user email in order table #5259

Merged
merged 5 commits into from
Oct 7, 2020
Merged

fix: search via user email in order table #5259

merged 5 commits into from
Oct 7, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #4237

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Oct 7, 2020
@vercel
Copy link

vercel bot commented Oct 7, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/8lqpehqo6
✅ Preview: https://open-event-fronten-git-d21d34641a74e75b237c14aeb9bdfcea5-42ec6f.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (development@9b346b3). Click here to learn what that means.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #5259   +/-   ##
==============================================
  Coverage               ?   22.82%           
==============================================
  Files                  ?      491           
  Lines                  ?     5227           
  Branches               ?       36           
==============================================
  Hits                   ?     1193           
  Misses                 ?     4029           
  Partials               ?        5           
Impacted Files Coverage Δ
app/routes/events/view/tickets/orders/list.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b346b3...ee653ea. Read the comment docs.

}
]
}
];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just push in search options if search is present. No need to create 2 more conditions like this. See the implementation of applySearchFilters

@iamareebjamal iamareebjamal merged commit f6f7ec8 into fossasia:development Oct 7, 2020
@maze-runnar maze-runnar deleted the free branch October 7, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants