fix: add overflow to notify-modal

[maze-runnar]

Fixes #5308

Checklist

• I have read the Contribution & Best practices Guide.
• My branch is up-to-date with the Upstream development branch.
• The acceptance, integration, unit tests and linter pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/n6egsw0qu
✅ Preview: https://open-event-frontend-git-theory-for-everything.eventyay.now.sh

[mariobehling]

Please test this PR with different sessions in different locations. Move the page and click notify. You will see that the pop up is at different locations and when you choose the first item it is off screen on some resolutions.

[mariobehling]

Do you see the html code below "Thank you"? Still there as well.

[maze-runnar]

Do you see the html code below "Thank you"? Still there as well.

regrading html code @iamareebjamal have said it -
#5308 (comment)

[iamareebjamal]

That HTML code is link to eventyay. According to the format you sent about the session state change

[iamareebjamal]

And about the modal position, this is the semantic UI issue I'm not sure fixable in this PR. This is general problem with any dialog as discussed before

[maze-runnar]

there are a lot of issues open regarding the single modal issue, that's confusing. I thing there should only be one issue opened not for each for each place.

[codecov]

Codecov Report

Merging #5319 into development will decrease coverage by 0.08%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development    #5319      +/-   ##
===============================================
- Coverage        22.78%   22.69%   -0.09%     
===============================================
  Files              491      491              
  Lines             5245     5243       -2     
  Branches            37       37              
===============================================
- Hits              1195     1190       -5     
- Misses            4045     4048       +3     
  Partials             5        5              

Impacted Files	Coverage Δ
app/models/event.js	31.25% <0.00%> (-18.75%)	⬇️
app/controllers/index.js	27.27% <0.00%> (-9.10%)	⬇️
app/controllers/public/index.js	6.34% <0.00%> (ø)
app/components/public/ticket-list.js	20.18% <0.00%> (ø)
app/controllers/admin/content/events.js	0.00% <0.00%> (ø)
app/controllers/events/view/sessions/list.js	0.00% <0.00%> (ø)
.../controllers/events/view/tickets/attendees/list.js	0.00% <0.00%> (ø)
app/controllers/register.js	36.36% <0.00%> (+2.07%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7971c4a...61cc97e. Read the comment docs.

[mariobehling]

If the issue cannot be fixed in this PR then probably the PR can be closed. We need to find a solution for the pop up model as it impacts different areas of the system and renders part of it unusable.

[mariobehling]

Or am I missing something. I am unclear what this PR fixes then.

Regarding the html code: I am afraid an organizer would be confused and delete it. Instead of <a href='{frontend_link}'>{app_name}</a> could we have something like {app_name_link} maybe?

[iamareebjamal]

I am unclear what this PR fixes then.

The PR fixes the modal part which was cut from up and down because of the message body. How there is a scrollbar so the modal won't be cut.

Regarding the html code: I am afraid an organizer would be confused and delete it. Instead of {app_name} could we have something like {app_name_link} maybe?

That can be done. But then it'll be just eventyay in the email and not eventyay

[mariobehling]

That can be done. But then it'll be just eventyay in the email and not eventyay

I understood {app_name} is just the app name but can we have {app_name_link} which includes the link instead of the html code?

[iamareebjamal]

I think it won't be clickable. It'll most likely be like https://eventyay.com, but I'll try it