Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show Location, Online Event, Mixed Event or To be Announced info correctly #5620

Merged
merged 1 commit into from
Nov 15, 2020

Conversation

sachinchauhan2889
Copy link
Contributor

@sachinchauhan2889 sachinchauhan2889 commented Nov 14, 2020

Fixes #5614

Short description of what this resolves:

This PR update the area to show the information according to the attendee pdf as follows:

  • When an event has a location, show "At" and the location behind.
  • When an event is an online event show "Online Event"
  • When the event is a mixed event show "Event taking place online and at [location here]."
  • When an event location or online details are "to be announced" show: "Location or online event details to be announced".

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

screenshots

s1

s2

s3

s4

@vercel
Copy link

vercel bot commented Nov 14, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/of8o6raac
✅ Preview: https://open-event-frontend-git-location-fix.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Nov 14, 2020

Codecov Report

Merging #5620 (0895b45) into development (8589e82) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5620      +/-   ##
===============================================
+ Coverage        23.73%   23.79%   +0.05%     
===============================================
  Files              498      498              
  Lines             5275     5275              
  Branches            47       47              
===============================================
+ Hits              1252     1255       +3     
+ Misses            4015     4012       -3     
  Partials             8        8              
Impacted Files Coverage Δ
app/components/tabbed-navigation.js 53.33% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d066002...0895b45. Read the comment docs.

@sachinchauhan2889 sachinchauhan2889 changed the title WIP: Show Location, Online Event, Mixed Event or To be Announced info correctly fix: Show Location, Online Event, Mixed Event or To be Announced info correctly Nov 15, 2020
@auto-label auto-label bot added the fix label Nov 15, 2020
@sachinchauhan2889
Copy link
Contributor Author

@iamareebjamal @mariobehling this PR is ready for review

@sachinchauhan2889
Copy link
Contributor Author

@iamareebjamal sir, this is also mentioned in #5614. Update location in event information box.

@iamareebjamal iamareebjamal merged commit cf9532c into fossasia:development Nov 15, 2020
@sachinchauhan2889 sachinchauhan2889 deleted the location-fix branch November 15, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order Page and Ticket PDF Download: Show Location, Online Event, Mixed Event or To be Announced info correctly
2 participants