Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce number of events on front page #5710

Merged
merged 1 commit into from
Nov 22, 2020

Conversation

sachinchauhan2889
Copy link
Contributor

Fixes #5579

Short description of what this resolves:

reduce events on front page.

  • Featured Events: 6
  • Upcoming Events: 12
  • Call for Speakers: 6

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/hrmnk5e49
✅ Preview: https://open-event-frontend-git-reduce-events.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Nov 21, 2020

Codecov Report

Merging #5710 (0944b91) into development (7c4f3e8) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5710      +/-   ##
===============================================
- Coverage        23.71%   23.66%   -0.06%     
===============================================
  Files              510      510              
  Lines             5422     5422              
  Branches            59       59              
===============================================
- Hits              1286     1283       -3     
- Misses            4121     4123       +2     
- Partials            15       16       +1     
Impacted Files Coverage Δ
app/routes/index.js 78.57% <ø> (ø)
app/services/cache.ts 64.15% <0.00%> (-5.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c4f3e8...0944b91. Read the comment docs.

@iamareebjamal iamareebjamal merged commit bdeb5b7 into fossasia:development Nov 22, 2020
@mariobehling
Copy link
Member

This does not result in the correct number of events on the front page.

@mariobehling
Copy link
Member

There is no link "More events" neither.

@sachinchauhan2889 sachinchauhan2889 deleted the reduce-events branch November 23, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Site Speed: Reduce number of events on front page
3 participants