Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make rooms sortable #5743

Merged
merged 2 commits into from
Nov 25, 2020
Merged

Conversation

codepool867
Copy link
Contributor

@codepool867 codepool867 commented Nov 24, 2020

Fixes #4164

Short description of what this resolves:

Make rooms custom-sortable by using Up and Down buttons.

Changes proposed in this pull request:

-specific room actions are inserted into session-speaker-form component
-Template is changed to add up and down button
-microlocation modal is changed to store position info

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 24, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/bz0gwd94l
✅ Preview: https://open-event-frontend-git-issue6.eventyay.now.sh

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #5743 (b91b8e7) into development (a7dd303) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5743      +/-   ##
===============================================
- Coverage        23.64%   23.49%   -0.15%     
===============================================
  Files              510      512       +2     
  Lines             5414     5474      +60     
  Branches            59       62       +3     
===============================================
+ Hits              1280     1286       +6     
- Misses            4118     4172      +54     
  Partials            16       16              
Impacted Files Coverage Δ
.../components/forms/wizard/sessions-speakers-step.js 0.00% <0.00%> (ø)
app/controllers/events/view/scheduler.js 0.00% <0.00%> (ø)
app/components/public/session-item.js 20.00% <0.00%> (-2.23%) ⬇️
app/router.js 100.00% <0.00%> (ø)
app/routes/public/sessions.js 0.00% <0.00%> (ø)
app/components/public/side-menu.js 0.00% <0.00%> (ø)
app/components/forms/orders/attendee-list.js 0.00% <0.00%> (ø)
app/components/public/stream/video-stream.ts 4.16% <0.00%> (ø)
app/routes/public/stream/view.ts 0.00% <0.00%> (ø)
app/components/tabbed-navigation.js 53.33% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b18409...b91b8e7. Read the comment docs.

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also see this comment in the issue: #4164 (comment)

The goal is to sort the rooms in the step by step guide and then display it in the same order in the scheduler.

@codepool867
Copy link
Contributor Author

Please also see this comment in the issue: #4164 (comment)

The goal is to sort the rooms in the step by step guide and then display it in the same order in the scheduler.

I fixed sorting issue in scheduler.

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Thank you.

@iamareebjamal iamareebjamal changed the title Wizard Step3/Scheduler: Rooms are not sortable feat: Make rooms sortable Nov 25, 2020
@auto-label auto-label bot added the feature label Nov 25, 2020
@iamareebjamal iamareebjamal merged commit f2d6609 into fossasia:development Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wizard Step3/Scheduler: Rooms are not sortable
3 participants