-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make rooms sortable #5743
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/bz0gwd94l |
Codecov Report
@@ Coverage Diff @@
## development #5743 +/- ##
===============================================
- Coverage 23.64% 23.49% -0.15%
===============================================
Files 510 512 +2
Lines 5414 5474 +60
Branches 59 62 +3
===============================================
+ Hits 1280 1286 +6
- Misses 4118 4172 +54
Partials 16 16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also see this comment in the issue: #4164 (comment)
The goal is to sort the rooms in the step by step guide and then display it in the same order in the scheduler.
I fixed sorting issue in scheduler. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. Thank you.
Fixes #4164
Short description of what this resolves:
Make rooms custom-sortable by using Up and Down buttons.
Changes proposed in this pull request:
-specific room actions are inserted into session-speaker-form component
-Template is changed to add up and down button
-microlocation modal is changed to store position info
Checklist
development
branch.