Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed style of Language Dropdown Button #9083

Conversation

adityagarg06
Copy link
Contributor

Fixes #9082

Short description of what this resolves:

Changed the style of the language dropdown button on the side-bar as required.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Aug 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-event-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2023 0:08am

@adityagarg06
Copy link
Contributor Author

@mariobehling I have done format-document, that's why there are so many changes in the file.

@mariobehling
Copy link
Member

Please add a screenshot to your PRs.

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good start.

Please change the following:

  1. Some rooms are not showing up and there are only 3 interpretation dropdowns instead of 4.
    Compare original https://eventyay.com/e/8f889410?side_panel=true
    Screenshot from 2023-08-12 01-58-26
    Compare Your PR
    Screenshot from 2023-08-12 01-57-17

  2. Please use same font color and indent for dropdown languages as the above button.

  3. Ensure the dropdown automatically adjusts its width to show the full language name, e.g. Bahasa Indonesia.
    Screenshot from 2023-08-12 01-55-58

@mariobehling
Copy link
Member

mariobehling commented Aug 11, 2023

Please also slightly reduce the font size of the "6".

@adityagarg06
Copy link
Contributor Author

Hi @mariobehling.
Is this fine, I cant move the dropdown to left as it will cover the left text. I can make the font size small.
2

And in my system I'm getting all 4 interpretation dropdowns
1

@mariobehling
Copy link
Member

mariobehling commented Aug 12, 2023

Did you commit all changes here? Using the deployment link above I am getting the following screen.

  • Please make the language text the same indent like the icon on the dropdown button itself (move it to the left)
  • Change font color to the same as the icon

Screenshot from 2023-08-13 01-23-01

@adityagarg06
Copy link
Contributor Author

@mariobehling I have made all changes and committed you can check it out now.

@mariobehling
Copy link
Member

Screenshot from 2023-08-13 23-52-11

Unfortunately the changes effect other areas.

@adityagarg06
Copy link
Contributor Author

@mariobehling I have made the changes and now it will not effect other areas.
image

@mariobehling
Copy link
Member

Thank you. This PR helped to get us on the right track and was solved elsewhere now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance language dropdown button
2 participants