Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move initial custom form creation to server #8205

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

progmatic-99
Copy link
Contributor

Fixes #7071

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

@auto-label auto-label bot added the feature label Sep 9, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #8205 (fd8a992) into development (d8e2054) will increase coverage by 0.03%.
The diff coverage is 93.54%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #8205      +/-   ##
===============================================
+ Coverage        65.74%   65.77%   +0.03%     
===============================================
  Files              305      305              
  Lines            15808    15828      +20     
===============================================
+ Hits             10393    10411      +18     
- Misses            5415     5417       +2     
Impacted Files Coverage Δ
app/models/custom_form.py 98.18% <ø> (ø)
app/api/events.py 52.86% <33.33%> (-0.34%) ⬇️
app/api/helpers/events.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8e2054...fd8a992. Read the comment docs.

@maze-runnar
Copy link
Contributor

@progmatic-99 please complete (frontend changes too) and then test it by yourself end to end.

@mariobehling
Copy link
Member

Please add the link to the frontend PR here as well. Thanks.

@mariobehling mariobehling changed the title feat: added custom form creation Move initial custom form creation to server Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move initial custom form creation on server from frontend
3 participants