-
Notifications
You must be signed in to change notification settings - Fork 857
Adds feature to view slides of the session #1878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/backend/_scss/application.scss
Outdated
position: absolute; | ||
right: 23px; | ||
top: 1px; | ||
.video, .slides { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each selector in a comma sequence should be on its own single line
src/backend/_scss/application.scss
Outdated
@@ -225,11 +225,17 @@ a { | |||
} | |||
|
|||
@media (min-width: 600px) { | |||
.video-iframe { | |||
.video-iframe , .iframe { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each selector in a comma sequence should be on its own single line
Codecov Report
@@ Coverage Diff @@
## development #1878 +/- ##
============================================
Coverage 72.81% 72.81%
============================================
Files 10 10
Lines 2358 2358
Branches 416 416
============================================
Hits 1717 1717
Misses 641 641
Continue to review full report at Codecov.
|
Let's follow best practices more closely as we progress. Please provide screenshots and test links. |
@mariobehling though slides URL are not available for any event, I tested it using dummy data. I am posting here a screenshot of the slideshow with test data - |
Asking again also in this issue.
|
@agbilotia1998 Can we try to use an open source viewer for the slides? |
@geekyd I searched for many slide-viewers but there are open source alternatives for pdf slides only, LibreOffice also does not any such iframe or embedded object in HTML. Any suggestions from your side? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging it for now. We will iterate from here.
Checklist
development
branch.Short description of what this resolves:
Adds option to view slides of the session
Fixes #1809