-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the Bottom Nav Sliding Direction Issue #2924
Conversation
Clicking on Delete Icon on the Toolbar now deletes all the images. Fixed issue when images of same name are added by changing the PrimaryKey from binPath to an auto_increment id. Fixed an issue in which files are not deleted from ".nomedia" directory. Also Updated some external library versions.
Clicking on Delete Icon on the Toolbar now deletes all the images. Fixed issue when images of same name are added by changing the PrimaryKey from binPath to an auto_increment id. Fixed an issue in which files are not deleted from ".nomedia" directory. Also Updated some external library versions.
Added a global variable to MyApplication Class. And applied tranisition based on logic/condtions to each of the three activity. NavItem starts from zero to two. Since we have three NavItems.
Thanks. Please resolve conflicts. |
Done . Sorry for that conflict 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed more than 2 issues in the same PR. Please only perform changes that are relevant to the issue. Also remove the irrelevant changes which are not to be done in a PR
Please review my comment, PR contains unnecessary code yet. |
@codedsun When building with SDK 29 ,
But compiling with SDK 28 resolves the issue. No crash occurs when run with versions < android 10 . |
@satyajiit Then what about the devices running on android 10? |
@codedsun I am testing the App on Android 10. Gradle build will succeed but if test the App on Android 10 , But If i build the project with Sdk28 and buildTools 28 , |
Fixed #2923
Changes: Added a global variable to MyApplication Class.
And applied transition based on logic/conditions to each of the three activities.
NavItem starts from zero to two.
Since we have three NavItems.
Added four new anim xml files and deleted the old two.
This PR also contains fix for #2894
GIF :