Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]: Implement susi music playback control #2299

Open
wants to merge 7 commits into
base: development
Choose a base branch
from
Open

[WIP]: Implement susi music playback control #2299

wants to merge 7 commits into from

Conversation

atm1504
Copy link
Member

@atm1504 atm1504 commented Jul 13, 2019

Fixes #2282

Changes:
Control the music service playback from the app.

Screenshots for the change:
Will be updated later

@ci-reporter
Copy link

ci-reporter bot commented Jul 13, 2019 •
edited
Loading

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 4ccabe7. Here's the output:

spotless check
> Task :app:spotlessKotlin FAILED

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!

Failed build for 4ccabe7
spotless check
> Task :app:spotlessKotlin FAILED
This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

@atm1504
Copy link
Member Author

atm1504 commented Jul 17, 2019

The work in this PR has been delayed due to problems in the susi smart speaker. I will resume the work after it is fixed. I have put up the errors in the gitter channel in susi_hardware.

@atm1504 atm1504 mentioned this pull request Jul 19, 2019
Open
@mariobehling
Copy link
Member

Please state what are the issues to complete this here in the tracker. We don't know where and when this was discussed. The final point of reference is always the tracker/PR discussion.

@atm1504
Copy link
Member Author

atm1504 commented Sep 1, 2019

Please state what are the issues to complete this here in the tracker. We don't know where and when this was discussed. The final point of reference is always the tracker/PR discussion.

Yah sure. I will mention all of the required points very soon.

iamrajatfzd
iamrajatfzd reviewed Jan 6, 2020
View reviewed changes
app/src/main/res/layout/fragment_music_servers.xml
@@ -40,7 +40,44 @@
android:layout_height="wrap_content"
android:layout_gravity="center_vertical"
android:layout_marginLeft="@dimen/margin_moderate"
android:text="Spotify"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

android:tect="spotify"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamrajatfzd iamrajatfzd iamrajatfzd left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

control the smart speaker via android app
3 participants
@atm1504 @mariobehling @iamrajatfzd