Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should use yarn instead of npm #107

Closed
4 tasks done
ms10398 opened this issue Feb 17, 2018 · 1 comment · Fixed by #108
Closed
4 tasks done

We should use yarn instead of npm #107

ms10398 opened this issue Feb 17, 2018 · 1 comment · Fixed by #108

Comments

@ms10398
Copy link
Member

ms10398 commented Feb 17, 2018

Actual Behaviour

Instead of npm we should use yarn. As its new and better.

Expected Behaviour

Yarn should be used as the package manager in the app.

Please check the applicable fields -
  • I ensure that this issue is not a duplicate of any current open issues(s).
  • Assign this issue to me (I want to work on this).
  • I will send my PR only after I'm assigned to this issue by any maintainer.
  • I understand that I will be unassigned from this issue if I fail to send a PR for this within a week.

@anshumanv need your views for it.

Will bundle up everything in a single PR if you give a thumbsup to do it.
@anshumanv
Copy link
Member

Sure we can use yarn, it's trending now and has some cool features, please do the needful! 😄

ms10398 added a commit to ms10398/susi_desktop that referenced this issue Feb 17, 2018
@ms10398
Fixes fossasia#105 fossasia#106 fossasia#107: yarn is added, now link…
07441a5 
…s open in default browser and electron is upadted to latest version
@ms10398 ms10398 mentioned this issue Feb 17, 2018
Merged
4 tasks
ms10398 added a commit to ms10398/susi_desktop that referenced this issue Feb 17, 2018
@ms10398
Fixes fossasia#105 fossasia#106 fossasia#107: yarn is added, now link…
ec89371 
…s open in default browser and electron is upadted to latest version

Fix Codacy and Travis
ms10398 added a commit to ms10398/susi_desktop that referenced this issue Feb 17, 2018
@ms10398
Fixes fossasia#105 fossasia#106 fossasia#107: yarn is added, now link…
0ea061d 
…s open in default browser and electron is upadted to latest version

Fix Travis and Codacy
ms10398 added a commit to ms10398/susi_desktop that referenced this issue Feb 17, 2018
@ms10398
Fixes fossasia#105 fossasia#106 fossasia#107: yarn is added, now link…
ed53e04 
…s open in default browser and electron is upadted to latest version

Fix Travis and Codacy
ms10398 added a commit to ms10398/susi_desktop that referenced this issue Feb 18, 2018
@ms10398
Fixes fossasia#105 fossasia#106 fossasia#107: yarn is added, now link…
66ffa98 
…s open in default browser and electron is upadted to latest version

Fix Travis and Codacy
ms10398 added a commit to ms10398/susi_desktop that referenced this issue Feb 18, 2018
@ms10398
Fixes fossasia#105 fossasia#106 fossasia#107: yarn is added, now link…
f46cc82 
…s open in default browser and electron is upadted to latest version

Fix Travis and Codacy
ms10398 added a commit to ms10398/susi_desktop that referenced this issue Feb 18, 2018
@ms10398
Fixes fossasia#105 fossasia#106 fossasia#107: yarn is added, now link…
4cecd67 
…s open in default browser and electron is upadted to latest version

Fix Travis and Codacy
ms10398 added a commit to ms10398/susi_desktop that referenced this issue Feb 18, 2018
@ms10398
Fixes fossasia#105 fossasia#106 fossasia#107: yarn is added, now link…
d420144 
…s open in default browser and electron is upadted to latest version

Fix Travis and Codacy

Add package-lock.json in gitignore
ms10398 added a commit to ms10398/susi_desktop that referenced this issue Feb 18, 2018
@ms10398
Fixes fossasia#105 fossasia#106 fossasia#107: yarn is added, now link…
b22e200 
…s open in default browser and electron is upadted to latest version

Fix Travis and Codacy

Add package-lock.json in gitignore
ms10398 added a commit to ms10398/susi_desktop that referenced this issue Feb 18, 2018
@ms10398
Fixes fossasia#105 fossasia#106 fossasia#107: yarn is added, now link…
765f3bc 
…s open in default browser and electron is upadted to latest version

Fix Travis and Codacy

Add package-lock.json in gitignore
BrainBuzzer added a commit that referenced this issue Feb 18, 2018
@BrainBuzzer
Merge pull request #108 from ms10398/master
936cef7 
Fixes #105 #106 #107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #105 #106 #107 ms10398/susi_desktop
2 participants
@anshumanv @ms10398