Fix #70 - Added option for custom server #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tstreamDOTh I noticed your last comment on this issue #70 after making this PR, just thought of working on this as the issue had been opened for quite some time. Please review this PR, I guess it will solve the purpose of custom server as of now :) |
Added option for custom server in settings page.
|
@djmgit I had clearly mentioned that it is being kept on hold since there is a lack of clarity on how its being implemented in the webchat. I have already worked on this but I am unable to test it because of some bugs which out of the scope of firefoxbot. |
|
@hkedia321 Please review |
hkedia321
reviewed
Oct 30, 2017
|
@hkedia321 Had the same issue. Then let's keep this on hold until we find a way to test it and verify the results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #70, Added option for custom server in settings page.