Using subprocess instead of os.system #250
Conversation
prateekiiest
changed the title
access_point/server/server.py
Outdated
| @@ -13,19 +13,19 @@ def install(): | |||
|
|
|||
| @app.route('/config/<stt>/<tts>/<hotword>/<wake>') | |||
| def config(stt, tts, hotword, wake): | |||
| os.system('sudo bash /home/pi/SUSI.AI/susi_linux/access_point/server/config.sh {} {} {} {}'.format(stt,tts,hotword,wake)) #nosec #pylint-disable type: ignore | |||
| subprocess.call(['sudo', 'bash' , '/home/pi/SUSI.AI/susi_linux/access_point/server/config.sh {} {} {} {}'.format(stt,tts,hotword,wake)]) #nosec #pylint-disable type: ignore | |||
There was a problem hiding this comment.
Replace with
subprocess.call(['sudo', 'bash' , '/home/pi/SUSI.AI/susi_linux/access_point/server/config.sh', stt, tts, hotword, wake])Or
subprocess.call(['sudo', 'bash' , 'server/config.sh', stt, tts, hotword, wake])to not stick to location of susi_linux.
There was a problem hiding this comment.
ok @hongquan making the changes wherever this exists
main/speech/TTS.py
Outdated
| 'flite -v -voice file://{0} -f {1} -o extras/output.wav'.format(flite_speech_file, filename)) | ||
| os.system('play extras/output.wav') | ||
| subprocess.call( | ||
| ['flite', '-v', '-voice', 'file://{0} -f {1} -o extras/output.wav'.format(flite_speech_file, filename)]) |
There was a problem hiding this comment.
You still haven't split all command parameters here.
|
Why do you make so many small commits which solve the same error?
There are a lot of errors similar to 0f92d73, why don't you fix at once? |
|
Sorry @hongquan I will squash all the commits together once I fix the errors. The current codacy issues https://app.codacy.com/app/fossasia/susi_linux/file/19482449645/issues/source?bid=5114668&fileBranchId=7972456#l34 So I believe we should avoid these particular issues, since we are not invoking shell here. |
prateekiiest
force-pushed
the
use-subprocess
branch
2 times, most recently
from
f975bf1
to
ed682a4
Compare
correct syntax fix codestyle issues fix trailing whitespace Update server.py fix trailing whitespace fix codacy issues parse the commands correctly for flite Fix all Codacy issues Fix all Codacy issues
prateekiiest
force-pushed
the
use-subprocess
branch
from
ed682a4
to
cb0d01d
Compare
|
Later on we will replace all "sudo bash" call under access_point server. |
Continuation of #245
Fixes #239