Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fiwix to 1.5.0-lb1 #396

Closed
rick-masters opened this issue Jan 6, 2024 · 0 comments · Fixed by #397
Closed

Update Fiwix to 1.5.0-lb1 #396

rick-masters opened this issue Jan 6, 2024 · 0 comments · Fixed by #397

Comments

@rick-masters
Copy link
Contributor

All patches for Fiwix have been pulled into the primary Fiwix github repo.
We can stop using the rick-masters fork and pull directly from https://github.com/mikaku/Fiwix

There is one significant change from the fork that should be explained.

In the fork, the madvise system call was implemented as an empty stub just so madvise did not return an error when called. This was to workaround a bug in musl 1.1.24 which would call madvise internally and then incorrectly propagate an error from the syscall back to the application program (in errno), causing a failure. It was ultimately decided that it was more appropriate to patch musl than workaround the problem in Fiwix.
More details can be found here.
The fix in the forthcoming PR mimics how musl 1.2.4 was fixed to ignore an error from madvise.

As a result of patching musl-1.1.24 many packages have new checksums in the forthcoming PR.

There are also changes to the way Fiwix is built.
Rather than passing many custom preprocessor definitions on the compiler command line, Fiwix now supports using custom header files to customize the kernel and so our definitions have been moved to these header files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant