-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): added delete group page #241
feat(ui): added delete group page #241
Conversation
> | ||
Select group to delete: | ||
</InputContainer> | ||
<Button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add a pop-up once user clicks on "Delete" and ask "Are you sure? " ??
Changes otherwise looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, my next task now.
ef9374d
to
bf6cca7
Compare
Done, you may review. |
bf6cca7
to
63a99fe
Compare
@dushimsam Can you please fix the testcases ? |
54bb6d4
to
670c614
Compare
sure, it was the problem of incompatible dependency but now they are fixed. |
@dushimsam : Have tested this branch working perfectly. but only issue is after deleting a group page is not getting refreshed. and data still stays in select which might be confusing for user. please make the changes accordingly. |
Signed-off-by: dushimsam <dushsam@gmail.com>
670c614
to
b645717
Compare
great , i have added the functionality of reloading the page at every successful delete operation. |
Signed-off-by: dushimsam dushsam@gmail.com
Description
Added delete group page.
Changes
src/Routes.jsx
How to test
npm start
http://localhost:PORT/admin/group/delete
Delete
button.Related Issue:
Fixes #234
@shaheemazmalmmd @GMishx