Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): added delete group page #241

Merged

Conversation

dushimsam
Copy link
Contributor

@dushimsam dushimsam commented Jul 13, 2022

Signed-off-by: dushimsam dushsam@gmail.com

Description

Added delete group page.

Changes

  1. Added a new file src/pages/Admin/Group/Delete/index.jsx for the UI feature.
  2. Introduced a new route in src/Routes.jsx
  3. Introduced new API callers for the UI integration.
  4. Added a new constant message for successful group deletion.

How to test

  1. Go to the project's main directory.
  2. run command npm start
  3. Visit the page at http://localhost:PORT/admin/group/delete
  4. You are going to see a list of deletable groups which you can select.
  5. Select the group you wish to delete then press Delete button.

delete_group_ui

Related Issue:

Fixes #234

@shaheemazmalmmd @GMishx

@GMishx GMishx added enhancement New feature or request needs review Need code review needs test Needs testing labels Jul 13, 2022
>
Select group to delete:
</InputContainer>
<Button
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a pop-up once user clicks on "Delete" and ask "Are you sure? " ??

Changes otherwise looks good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, my next task now.

@GMishx GMishx removed the needs review Need code review label Jul 13, 2022
@dushimsam dushimsam force-pushed the dushimsam/feat/admin/delete-group branch from ef9374d to bf6cca7 Compare August 9, 2022 05:45
@dushimsam
Copy link
Contributor Author

dushimsam commented Aug 9, 2022

Done, you may review.

@dushimsam dushimsam force-pushed the dushimsam/feat/admin/delete-group branch from bf6cca7 to 63a99fe Compare August 10, 2022 04:02
@dushimsam dushimsam requested a review from GMishx August 22, 2022 19:28
@shaheemazmalmmd
Copy link
Member

@dushimsam Can you please fix the testcases ?

@dushimsam dushimsam force-pushed the dushimsam/feat/admin/delete-group branch 3 times, most recently from 54bb6d4 to 670c614 Compare August 26, 2022 07:35
@dushimsam
Copy link
Contributor Author

dushimsam commented Aug 26, 2022

@dushimsam Can you please fix the testcases ?

sure, it was the problem of incompatible dependency but now they are fixed.

@shaheemazmalmmd
Copy link
Member

@dushimsam : Have tested this branch working perfectly. but only issue is after deleting a group page is not getting refreshed. and data still stays in select which might be confusing for user. please make the changes accordingly.

Signed-off-by: dushimsam <dushsam@gmail.com>
@dushimsam dushimsam force-pushed the dushimsam/feat/admin/delete-group branch from 670c614 to b645717 Compare August 26, 2022 11:57
@dushimsam
Copy link
Contributor Author

@dushimsam : Have tested this branch working perfectly. but only issue is after deleting a group page is not getting refreshed. and data still stays in select which might be confusing for user. please make the changes accordingly.

great , i have added the functionality of reloading the page at every successful delete operation.
you may review

@shaheemazmalmmd shaheemazmalmmd merged commit b175625 into fossology:main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs test Needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creation of the Delete Group page
3 participants