fix(copyright): Make check strict #2011
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While editing/fetching the copyrights, the association with uploadtree_pk was not very strong. It caused issue while editing copyrights from a single file view instead of aggregated table view.
This causes problem when same upload has duplicate files. Since
copyright
table holds information ofpfile_fk
andagent_fk
only, there will be only one entry for a copyright in those files. But if someone made some changes, thecopyright_event
is involved which takesuploadtree_fk
into account. This caused ambiguity on which copyright to show.Changes
uploadtree_fk
while fetching copyrights to get only relevant copyrights.copyright_event
to make sure alluploadtree_fk
are updated.How to test