Item9593: add some feedback for the admin if their setup implies Apache Digest Auth. I didn't find a way for our cgi app to ask apache what its setting for AuthName is

git-svn-id: http://svn.foswiki.org/trunk@8833 0b4bb1d4-4e5a-0410-9cc4-b2b747904278

Author: SvenDowideit

core/lib/Foswiki/Configure/Checkers/AuthRealm.pm

@@ -0,0 +1,52 @@
+# See bottom of file for license and copyright information
+package Foswiki::Configure::Checkers::AuthRealm;
+
+use strict;
+use warnings;
+
+use Foswiki::Configure::Checker ();
+our @ISA = ('Foswiki::Configure::Checker');
+
+sub check {
+    my $this = shift;
+    
+    if ( !$Foswiki::cfg{AuthRealm} ) {
+        return $this->ERROR(
+'Please make sure you enter an Authentication Realm. This is required for registration to work.'
+        );
+    }
+
+    if (( $Foswiki::cfg{AuthRealm} =~ /\:/ ) and 
+#        ($Foswiki::cfg{AuthRealm} eq 'Foswiki::LoginManager::ApacheLogin') and
+        ($Foswiki::cfg{Htpasswd}{Encoding} eq 'md5')) {
+            return $this->ERROR("Digest auth (md5) password files store the AuthRealm in the password file, which uses ':' (colons) as the data separator. Please remove the colon from the Setting.");
+    }
+    return '';
+}
+
+1;
+__END__
+Foswiki - The Free and Open Source Wiki, http://foswiki.org/
+
+Copyright (C) 2008-2010 Foswiki Contributors. Foswiki Contributors
+are listed in the AUTHORS file in the root of this distribution.
+NOTE: Please extend that file, not this notice.
+
+Additional copyrights apply to some or all of the code in this
+file as follows:
+
+Copyright (C) 2000-2006 TWiki Contributors. All Rights Reserved.
+TWiki Contributors are listed in the AUTHORS file in the root
+of this distribution. NOTE: Please extend that file, not this notice.
+
+This program is free software; you can redistribute it and/or
+modify it under the terms of the GNU General Public License
+as published by the Free Software Foundation; either version 2
+of the License, or (at your option) any later version. For
+more details read LICENSE in the root of this distribution.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
+
+As per the GPL, removal of this notice is prohibited.

core/lib/Foswiki/Configure/Checkers/LoginManager.pm

@@ -36,6 +36,17 @@ will have to log in every time you access an authenticated page. To avoid
 this, you are recommended to turn {UseClientSessions} on.
 HERE
     }
+    if ( $Foswiki::cfg{LoginManager} =~ /ApacheLogin$/
+        && ($Foswiki::cfg{Htpasswd}{Encoding} eq 'md5') )
+    {
+        $e .= $this->WARN(<<'HERE');
+Combining ApacheLogin and md5 password encoding requires the foswiki 
+Authentication settings in the web server setup to be set to use Digest mode.
+This also requires the AuthName setting in the webserver 
+configuration to be the same as the foswiki AuthRealm setting.
+HERE
+    }
+
     return $e;
 }
 

core/lib/Foswiki/Contrib/core/MANIFEST

@@ -431,6 +431,7 @@ lib/Foswiki/Cache/MemoryLRU.pm 0444
 lib/Foswiki/Cache.pm 0444
 lib/Foswiki/Compatibility.pm 0444
 lib/Foswiki/Configure/Checker.pm 0444
+lib/Foswiki/Configure/Checkers/AuthRealm.pm 0444
 lib/Foswiki/Configure/Checkers/AuthScripts.pm 0444
 lib/Foswiki/Configure/Checkers/AllowInlineScript.pm 0444
 lib/Foswiki/Configure/Checkers/BasicSanity.pm 0444