Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item14530: Fix Query.pm to show correct "File System Paths" #19

Merged
merged 2 commits into from
Dec 8, 2017

Conversation

bixycler
Copy link
Contributor

  • Fix bootstrapping values of $Foswiki::cfg{$bsdir} in function getspec()

- Fix bootstrapping values of $Foswiki::cfg{$bsdir} in function getspec()
@bixycler
Copy link
Contributor Author

@gac410, would you please review this small patch to fix the "known issue" in Item14530.

@vrurg
Copy link
Member

vrurg commented Nov 30, 2017

Before merging the request may I suggest changing bsdir/BSDIRS to a more descriptive name? What does 'BS' stands for? I would suspect it is a shorthand for 'base' but could also be 'basic', 'big storage', etc...

@gac410 gac410 merged commit 2cf7b18 into foswiki:Item14530 Dec 8, 2017
@gac410
Copy link
Member

gac410 commented Mar 9, 2018

bixycler, here is a status update on merge plans for 2.2. I did a trial merge and some testing. I ran into a couple of issues.

  1. On a site that is migrating from a 2.1/2.0 configuration, the RootDir remains unset. It doesn't cause any problems initially, but the default value remains /home/httpd/foswiki, which might cause issues when saved. I added some code to initialize the setting during config load, and hit a 2nd issue.
  2. pseudo-install.pl does a "require" to check for dependencies, and this causes Foswiki modules to initialize before LocalSite.cfg is created. My fix for point 1 went into a hard loop.

Anyway, I do plan to get this into 2.2, but it needs a bit more work, and we should probably clean up pseudo-install.pl to use Foswiki::Configure::FileUtil::findFileOnPath() to resolve dependencies rather than "require", which triggers all sorts of initialization code prematurely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants