Fix operand white space for libsass compilation #6832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to compile this on libsass today I noticed that it was unable to read past the operands due to the code style of the html5number mixin.
|
Let us know if you continue to have problems with this, we are closing it for now. Thank you! |
|
@zurbchris This is still an issue for me. I understand this could be fixed in the latest libsass, however I'm behind a dependency wall at the moment. I think my commits do contribute to your code style and would be worth the merge. If there's anything else I can provide to help this move forward let me know. |
|
After further review from one of our Sass specialists, we're going to pull this in. Thanks for the contribution! |
zurbchris
added a commit
that referenced
this pull request
Sep 2, 2015
Fix operand white space for libsass compilation, quotations on url
|
After further review from one of our Sass specialists, we're going to pull this in. Thanks for the contribution! |
|
@zurbchris No problem, thanks for the quick review and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to compile this on libsass today I noticed that it was unable to read past the operands due to the code style of the html5number mixin.