Flexbox mixins & helper classes for direction, container, … #9324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm still getting to grips with flexbox, but this looks brilliant from my first look over everything 👍 |
ncoden
approved these changes
Nov 7, 2016
rafibomb
reviewed
Nov 14, 2016
| - `.flex-direct-row` (default) | ||
| - `.flex-direct-row-reverse` | ||
| - `.flex-direct-column` | ||
| - `.flex-direct-column-reverse` |
There was a problem hiding this comment.
Can we call it flex-dir-row? Dir is more shorthand direct and dont want to type out direction 😜
rafibomb
reviewed
Nov 14, 2016
|
|
||
| .flex-child-grow { | ||
| flex: 1 0 auto; | ||
| } |
There was a problem hiding this comment.
Might need a media query for these. Like .small-flex-child-auto & .medium-flex-child-grow
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass on some mixins and helper classes for managing flex alignment etc. Addresses #9208