Templates render _only_ the style node

[sdhull]

Am I doing something obviously wrong?

Site is open source, feel free to check it out. Branch is here. When I visit the email preview (or send the email from console), the resulting email has the email layout and the <style> node from the template but nothing else.

What gives? I even tried updating to use latest master from github. I also had an issue with compatibility of foundation-rails and foundation-emails.

[marcandre]

Sorry about that... It's a bug that happens for views with more than one root node.

It should be fixed in the next few days, this commit in #32 addresses that. Feel free to try that branch if you want in the meantime...

I'll close this issue when I release it.

[marcandre]

Should be completely addressed with 1.3.7.0. Let us know if that's not the case! Thanks for reporting this.

[sdhull]

Looks like this fixes the issue! Thank you!

[sdhull]

So what I found tonight is that while this appeared to work properly in my local dev environment, it's not working for me on my staging environment on Heroku...

[marcandre]

@sdhull Probably an issue with deploying?
From the Ruby console, check the result of Inky::Rails::VERSION

[sdhull]

Yeah, I thought it was maybe something like that too, however from heroku console:

irb(main):008:0> Inky::Rails::VERSION
=> "1.3.7.0"

When I try to send emails from the console, inky templates don't send at all. When I inspect the mail object returned, the body is nil.

irb(main):005:0> mail.html_part
=> nil

But emails with just html templates send fine (I haven't converted existing templates to inky).

[marcandre]

Mmm, so it's not the same bug (the <style> used to render), right?

Ideally open a new issue, but I won't be able to check it out let alone fix it unless you manage to dig a bit further. The gem is quite small, and there's a rails test so maybe you can figure out what's causing the issue?

[sdhull]

Figured it out. Submitted a PR to fix it.

[sdhull]

Yeah, I thought it was maybe something like that too, however from heroku
console:

irb(main):008:0> Inky::Rails::VERSION
=> "1.3.7.0"

When I try to send emails from the console, inky templates don't send at
all. When I inspect the mail object returned, the body is nil.

irb(main):005:0> mail.html_part
=> nil

But emails with just html templates send fine (I haven't converted existing
templates to inky). I guess maybe the gem isn't ready for primetime and I
should just convert my views back to html.erb :(

[marcandre]

Probably an issue with deploying?
From the Ruby console, check Inky::Rails::VERSION

On Fri, Oct 21, 2016 at 3:36 AM, Steve notifications@github.com wrote:

So what I found tonight is that while this appeared to work properly in my
local dev environment, it's not working for me on my staging environment on
Heroku...

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#35 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AACD6nw8CMCl6u-O3QrhZtuEX3zJGGleks5q2GuZgaJpZM4KS2_N
.

[sdhull]

lol sorry I sent that last Friday while Dyn was under attack. When Dyn had recovered I just came to Github and left the comment. Apparently the DDoS attack delayed the processing of this email. You can ignore this, sorry.