Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing locale bug #2

Merged
merged 4 commits into from Feb 6, 2015
Merged

Fixing locale bug #2

merged 4 commits into from Feb 6, 2015

Conversation

ghinch
Copy link
Contributor

@ghinch ghinch commented Feb 6, 2015

locale is already in the results usually, so setting always explicitly setting it was throwing an exception for having double kwargs. Tests pass now.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.21%) to 96.56% when pulling 0bfd984 on growthstreet:bugfixes into caaf9a6 on founders4schools:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.21%) to 96.56% when pulling 0bfd984 on growthstreet:bugfixes into caaf9a6 on founders4schools:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 96.81% when pulling 888ffd8 on growthstreet:bugfixes into caaf9a6 on founders4schools:master.

@ghinch
Copy link
Contributor Author

ghinch commented Feb 6, 2015

Having trouble getting tests passing when it relies on external connection. Would be good to look at using Mock or similar as a replacement

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 96.81% when pulling 5808c6a on growthstreet:bugfixes into caaf9a6 on founders4schools:master.

cleder added a commit that referenced this pull request Feb 6, 2015
Fixing locale bug - Thanks :-)
@cleder cleder merged commit 588f22f into founders4schools:master Feb 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants