Fix image layer meta gathering #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-sul
force-pushed
the
fix-image-layer-meta-gathering
branch
2 times, most recently
from
638d6b5
to
b77bd38
Compare
mike-sul
force-pushed
the
fix-image-layer-meta-gathering
branch
4 times, most recently
from
7339fbb
to
2c436b9
Compare
If an image was not pulled or pushed by the docker CLI command then there is no map between image layer diff IDs and digest. This change adjust the layer meta gathering algorithm to this case. Specifically, it fetches image manifest and gets image layer digests from it. Signed-off-by: Mike Sul <mike.sul@foundries.io>
mike-sul
force-pushed
the
fix-image-layer-meta-gathering
branch
from
0026efd
to
1c3ec86
Compare
doanac
reviewed
Jun 17, 2024
apps/build.sh
Outdated
| @@ -17,7 +17,7 @@ HERE=$(dirname $(readlink -f $0)) | |||
| require_params FACTORY | |||
|
|
|||
| export DOCKER_BUILDKIT=1 | |||
| BUILDKIT_VERSION="${BUILDKIT_VERSION-v0.10.3}" | |||
| BUILDKIT_VERSION="${BUILDKIT_VERSION-v0.13.1}" | |||
There was a problem hiding this comment.
are we sure this change is needed. If so - can we update the commit message to explain why?
Also - Can we bump this without bumping the docker-dind-ci container image?
There was a problem hiding this comment.
No, I am not sure. Let me double check it.
There was a problem hiding this comment.
| #1 DONE 5.5s
| ERROR: multiple outputs currently unsupported by the current BuildKit daemon, please upgrade to version v0.13+ or use a single output
1c3ec86
to
8b61115
Compare
doanac
reviewed
Jun 17, 2024
mike-sul
force-pushed
the
fix-image-layer-meta-gathering
branch
from
8b61115
to
50007ef
Compare
If buildkit and buildx supports multiple outputs then: - Load built images to the local docker store. - Push/output built images to registry. Make sure the OCI types are not used and create an image manifest not index. Signed-off-by: Mike Sul <mike.sul@foundries.io>
mike-sul
force-pushed
the
fix-image-layer-meta-gathering
branch
from
50007ef
to
0435867
Compare
doanac
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.