Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: check for warnings #403

Merged
merged 1 commit into from
Jun 25, 2023
Merged

ci: check for warnings #403

merged 1 commit into from
Jun 25, 2023

Conversation

ZeroEkkusu
Copy link
Collaborator

Motivation

Resolve #402

Solution

Fail CI if there's Warning in output.

@ZeroEkkusu ZeroEkkusu requested a review from mds1 June 17, 2023 18:02
onbjerg
onbjerg approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

mds1
mds1 approved these changes Jun 25, 2023
View reviewed changes
Copy link
Collaborator

@mds1 mds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, thanks!

@mds1 mds1 merged commit 5b54014 into master Jun 25, 2023
@mds1 mds1 mentioned this pull request Jun 25, 2023
Merged
@DaniPopes DaniPopes deleted the ci/warnings branch October 24, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@mds1 mds1 mds1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: check for warnings
3 participants
@ZeroEkkusu @onbjerg @mds1