Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add debug logs #29

Merged
merged 2 commits into from
Feb 28, 2023
Merged

feat: add debug logs #29

merged 2 commits into from
Feb 28, 2023

Conversation

DaniPopes
Copy link
Member

As of recent the action has been failing sporadically with 404 errors:

This PR introduces some sanity check / debug logs

@onbjerg
Copy link
Member

onbjerg commented Feb 28, 2023

How did you compile? The dist/index.js looks suspiciously small for this change

onbjerg
onbjerg approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm, checked out locally and built manually, lgtm

Edit: Nvm, apparently it is different on CI? We have to build with Node.js 16

@onbjerg onbjerg merged commit 3936f9d into foundry-rs:master Feb 28, 2023
@DaniPopes DaniPopes deleted the debug branch February 28, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @onbjerg