feat(cheatcode): coinbase(address) - modify block.coinbase #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mds1
reviewed
May 4, 2022
evm/src/executor/abi.rs
Outdated
| @@ -17,6 +17,7 @@ ethers::contract::abigen!( | |||
| roll(uint256) | |||
| warp(uint256) | |||
| fee(uint256) | |||
| bank(address) | |||
There was a problem hiding this comment.
I think naming the cheatcode coinbase would be more clear/intuitive, and consistent with fee and chainId. Otherwise LGTM! 🙂
There was a problem hiding this comment.
Sounds good, updated accordingly
wardbradt
changed the title
This was referenced May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the cheat code
bank(address)which setsblock.coinbaseby internally modifyingdata.env.block.coinbase.I'm not too familiar with foundry's internals, so I'm not highly confident that this doesn't break something unexpected. But it is a pretty small change and all tests pass.
Motivation
This is useful for testing contracts that depend on the value of
block.coinbase.