fix: forge create Contract
#295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously you had to specify the full path, and it'd panic if you only provided a name
gakonst
force-pushed
the
fix/create-with-name
branch
from
493651c
to
80a7a1b
Compare
clifton
pushed a commit
to clifton/foundry
that referenced
this pull request
Dec 27, 2021
previously you had to specify the full path, and it'd panic if you only provided a name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, you could only
forge create path/Contract.sol:ContractName, and if you didforge create ContractNameit'd panic the first time it runs because there's no such artifact in the cache yet.With this PR you can just
forge create ContractName, and if there's 2 with the same ones it proceeds to error out and ask you to provide the full path