Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle natural 1s and 20s on spell check rolls #53

Closed
algnc opened this issue Sep 3, 2020 · 4 comments
Closed

Handle natural 1s and 20s on spell check rolls #53

algnc opened this issue Sep 3, 2020 · 4 comments
Assignees
Labels
bug Something isn't working fix-pending A fix exists outside of master and will be applied soon
Milestone

Comments

@algnc
Copy link
Contributor

algnc commented Sep 3, 2020

Checking for natural 1s on spell rolls would indicate when corruption or a misfire occured. it could also check for natural 20s to add double caster level.

edit: actually, I see now you get a red number on a 1. That should work. Natural 20 could double caster level which would be nice.

@mooped mooped added the enhancement New feature or request label Sep 13, 2020
@mooped mooped changed the title Check for natural 1s on spell rolls Handle natural 20s on spell check rolls Oct 24, 2020
@mooped
Copy link
Contributor

mooped commented Oct 24, 2020

Updated title to reflect the edit.

@mooped mooped added this to the For v1.0 milestone Feb 6, 2021
@mooped
Copy link
Contributor

mooped commented Feb 10, 2021

Likewise we should handle natural 1s which seem to be another special case.

@cyface cyface removed the for v1.0 label Mar 6, 2021
@mooped mooped changed the title Handle natural 20s on spell check rolls Handle natural 1s and 20s on spell check rolls Mar 10, 2021
@mooped mooped self-assigned this Mar 10, 2021
@mooped mooped added the fix-pending A fix exists outside of master and will be applied soon label Mar 14, 2021
mooped added a commit that referenced this issue Mar 14, 2021
@mooped mooped added bug Something isn't working and removed enhancement New feature or request labels Mar 15, 2021
@cyface
Copy link
Collaborator

cyface commented Apr 2, 2021

@algnc can you validate this one in preview-0.24?

@algnc
Copy link
Contributor Author

algnc commented Apr 2, 2021

both fumble and crit roll and total their rolls correctly now!

@algnc algnc closed this as completed Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix-pending A fix exists outside of master and will be applied soon
Projects
None yet
Development

No branches or pull requests

3 participants