Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow +dice in initiative #86

Closed
algnc opened this issue Oct 23, 2020 · 3 comments · Fixed by #100
Closed

allow +dice in initiative #86

algnc opened this issue Oct 23, 2020 · 3 comments · Fixed by #100
Assignees
@mooped
Labels
enhancement New feature or request fix-pending A fix exists outside of master and will be applied soon

Comments

@algnc
Copy link
Contributor

algnc commented Oct 23, 2020

The Mutant in MCC has +dice to initiative, +1d3 for example. It would be nice if their initiative could be +1+1d3 for example.
@mooped
Copy link
Contributor

mooped commented Oct 23, 2020

image

How do you feel about this solution @algnc ?

It also allows handling the 1 handed/2 handed situation also while keeping the validation on the modifier section.

@mooped
Copy link
Contributor

mooped commented Oct 23, 2020

I've not applied it to NPCs or zeroes yet. NPCs usually always roll a d20 and zeroes have enough problems, though other judges may disagree.

@mooped mooped mentioned this issue Oct 23, 2020
Closed
@mooped mooped self-assigned this Oct 23, 2020
@mooped mooped added the enhancement New feature or request label Oct 23, 2020
@algnc
Copy link
Contributor Author

algnc commented Oct 23, 2020

That looks great

mooped added a commit to mooped/foundryvtt-dcc that referenced this issue Oct 24, 2020
@mooped
Separate die and modifier for Cast Spell From Scroll.
2271de3 
Separate die and modifier for initiative rolls.
Closes foundryvtt-dcc#65
Closes foundryvtt-dcc#86
@mooped mooped added the fix-pending A fix exists outside of master and will be applied soon label Oct 24, 2020
@mooped mooped mentioned this issue Nov 1, 2020
Merged
cyface pushed a commit that referenced this issue Nov 1, 2020
@mooped
Lots of enhancements and bug fixes (#100)
7e25662 
* Update compatibleCoreVersion to 0.7.5.

* Separate die and modifier for Cast Spell From Scroll.
Separate die and modifier for initiative rolls.
Closes #65
Closes #86

* Initial implementation of rollable treasure and currency conversion (for
coins).

* Tidy value rolls and currency conversion.
Closes #80
Closes #87

* Use action die for relevant rolls.
Closes #55

* Saves are always rolled on a d20.

* Formatting pass and fix up tests to handle action die changes.

* Handle multiple action dice.
Action dice are set in the config dialog and selected from a dropdown
where the actionDice text field was.
Zeroes always use the first action dice defined in the config.
Closes #90

* Action Dice can be dragged to the macro bar to create a macro that
selects the current die.

* Add maximum fields for abilities and support showing them on the sheet.
Closes #88

* Populate ability score maximums with the initial ability score.

* Implement basic upper level character parsing.
Put some zero level fields in the right places.

* Cleric upper level import passing tests.

* Fix import of treasure items.
Avoid potential nasty infinite recursion when combining As Coins items.

* Handle upper level thieves.

* Parse upper level halfling stats.
Formatting pass.

* Upper level warrior parsing.

* Upper level wizard and dwarf parsing.

* Parse upper level Elf stats.
Closes #90

* Put back template for the 'results' field of spells.

* Validate and format speed field as a distance in feet.
Closes #97

* Remove ability label if a class doesn't have a spellCheckAbility
defined.
Closes #92

* Run formatter.

* Use roll.roll() over roll.evaluate() for compatibility with 0.6.6.

* Rename Show Max Attributes to the more correct Show Max Abilities

* Bump minimal compatible version to 0.6.6 as I'm currently testing on that and latest.

* Bump to 0.16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mooped mooped

Labels
enhancement New feature or request fix-pending A fix exists outside of master and will be applied soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lots of enhancements and bug fixes mooped/foundryvtt-dcc
2 participants
@mooped @algnc